Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade graphql dependency to major 16 #1174

Closed
wants to merge 2 commits into from

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Jan 18, 2022

fixes #1100

All tests pass except this one
image

The only problem is that I cannot find the version of graphql-tools which had SchemaDirectiveVisitor, I have checked out the whole repo and greped it on older commits, like for example on f0cb92e1361d10294b12a20188c2e1d57b92a543 and it's not there.
So if anyone can help me find source code for SchemaDirectiveVisitor, I can publish it on npm as separate module and we can fix that last test.

@MichalLytek
Copy link
Owner

I appreciate your work but I already have almost working v16 upgrade on my own branch:
https://github.com/MichalLytek/type-graphql/tree/v16

I only haven't enough time to migrate directive tests to the new graphql tools because they now do not support transforming input values. I have to dig more or refactor the tests as I only care about AST, not about whole ecosystem flow.

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Duplicate 🔑 This issue or pull request already exists Enhancement 🆕 New feature or request labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Duplicate 🔑 This issue or pull request already exists Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL.js v16 support
2 participants