-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog app: Add Authorization Rules #10
Conversation
…tack-Program/rails-blog-app into add-authorization-rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cherelemma and @Tshobohwa ,
Very nice project. I love the way you have created a descriptive pull request message. Great work👏🏿 . However, there are a few changes to be made kindly check below ⬇️
Highlights!
[ ] Good feature branch name ✔️
[ ] Descriptive pull request ✔️
[ ] Great UI design ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread or tag me @peterrobert if something is not 100% clear.
As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Team,
Your project is complete! There is nothing else to say other than... it's time to merge it
STATUS: APPROVED 🟢
Congratulations! 🎉
- Check the inline comments under the review for sections to improve.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
- [OPTIONAL] I am adding this recommendation here because the README file is not part of the file changes. It is highly required of a pair-programming project that its README file contains the details of both authors of the project. Kindly add the details of the second contributor in the Author section of the README.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Dear CR ✋
I hope this message finds you well. I am submitting a pull request for your review and feedback on the implementation of the Blog app: add authorization rules. I, @cherelemma, and @Tshobohwa collaborate to implement the project requirements. We believe that our implementation fulfills the project requirements and maintains the general requirements.
Project Requirements ✔️
role
column to the users table. Remember to use a migration for this.role
has value"admin"
). Use CanCanCan for this authorization.role
has value"admin"
). Use CanCanCan for this authorization.General requirements ✔️
We have thoroughly reviewed the project requirements and cross-checked the implementation of the authorization of the Blog app against the given description to ensure accuracy. All necessary views have been run successfully.
We kindly request a review as your feedback and suggestions are invaluable in ensuring the quality and efficiency of the project.
Thank you in advance for your time and help. We are looking forward to your feedback and addressing any concerns to enhance the overall quality of the project.