Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blog app] Milestone 4 - Create Controllers #4

Merged
merged 12 commits into from
Jun 29, 2023
Merged

Conversation

cherelemma
Copy link
Contributor

Hello Dear CR ✋

I hope this message finds you well. I am submitting a pull request for your review and feedback on the implementation of the Blog app - controllers. I believe the implementation fulfills the project requirements and also maintained the general requirements.

Project Requirements ✔️

  • Important: Do NOT use the rails generate scaffold command. The point of this project is to show you how to set up controllers by yourself.
  • Take a look at the wireframes below. Make sure that your app handles the URLs used in the wireframes:

All users page wireframe Single user page wireframe All posts by a given user page wireframe Single post page wireframe

  • For each URL you should create:

    • A route.
    • An action in the correct controller.
    • A view file.
  • View files should include only placeholders written in plain HTML, e.g:

    • Here is a list of posts for a given user
  • Make sure that you added code to handle only the 4 required URLs.

Make sure that when you run the rails routes command in your console, you can see the following output:

Single Post page wireframe

General requirements ✔️

I have thoroughly reviewed the project requirements and cross-checked the implemented controllers and views for the Blog app against the given description to ensure accuracy. All necessary controllers and views have been run successfully.

I kindly request a review as your feedback and suggestions are invaluable in ensuring the quality and efficiency of the project.

Thank you in advance for your time and assistance. I'm looking forward to your feedback and addressing any concerns to enhance the overall quality of the project.

Copy link

@addod19 addod19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cherelemma,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Correct Git-flow followed 💯
  • README file is professional and has all the relevant headers 🎆
  • PR is descriptive 👍
  • Controller actions matches with the views 🚀
  • Only required routes are exposed 🥇

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

spec/helpers/posts_helper_spec.rb Show resolved Hide resolved
Copy link

@mikethreels mikethreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Urgaya,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • good job creating the controller specs

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@cherelemma cherelemma merged commit aabb468 into dev Jun 29, 2023
@cherelemma cherelemma added this to the Blog App milestone Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants