-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blog app] Milestone 4 - Create Controllers #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cherelemma,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- Correct Git-flow followed 💯
- README file is professional and has all the relevant headers 🎆
- PR is descriptive 👍
- Controller actions matches with the views 🚀
- Only required routes are exposed 🥇
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Urgaya,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- good job creating the controller specs
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Dear CR ✋
I hope this message finds you well. I am submitting a pull request for your review and feedback on the implementation of the Blog app - controllers. I believe the implementation fulfills the project requirements and also maintained the general requirements.
Project Requirements ✔️
rails generate scaffold
command. The point of this project is to show you how to set up controllers by yourself.For each URL you should create:
View files should include only placeholders written in plain HTML, e.g:
Make sure that you added code to handle only the 4 required URLs.
Make sure that when you run the
rails routes
command in your console, you can see the following output:General requirements ✔️
I have thoroughly reviewed the project requirements and cross-checked the implemented controllers and views for the Blog app against the given description to ensure accuracy. All necessary controllers and views have been run successfully.
I kindly request a review as your feedback and suggestions are invaluable in ensuring the quality and efficiency of the project.
Thank you in advance for your time and assistance. I'm looking forward to your feedback and addressing any concerns to enhance the overall quality of the project.