addition of a abstract syntax tree to source code printer #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble to make a subclass using this class see exampleDiagnostic.py
…ree in python. The syntaxFactory bindings do not work yet.
…their parameters is supported
…names are written
…done this way because the information needed to remake the source code (the genvar expresion, itteration,....) are not present in the ast.I added more binary operators and made cosmetic changes to InstanceBody
…ow possible to make a subclass using this class see exampleDiagnostic.py" This reverts commit c646605.
…nto astPrinterRelease
… to making it compatible with the changes in the ast
|
Thanks for submitting a PR. Please get the tests and pre-commit checks to pass and revert any changes that aren't required to be part of this diff, such as the changes to the build workflow. Also from a higher level point of view I'm not against adding a printer for the AST but I'm curious what your use case is and whether the printer really needs to live in the slang library or could just exist in a downstream application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
his pull request introduces the initial implementation of an AST to Source Code Printer as part of a recent internship project. The goal of this addition is to enable the conversion of AST representations back into human-readable source code. Currently, the functionality is limited to handling simple programs, more complex programs may not be accurately represented yet. The current version lacks support for 'property', 'checker', 'cover', and 'generate' statements, although it does provide basic support for other elements .
changes to the orginal AST are the addition of a 'name' member to the CovergroupType and corresponding updates to the JSON AST printer. A 'isDuplicate' flag has been introduced to VariableFlags to track duplicate information. Furthermore, a 'MinimalInfoEnabled' option has been added to the serializer, producing a JSON output with reduced information, facilitating the comparison of different ASTs for equivalence.
A test suite based on the 'all.sv' file has been made. Programs are validated by running the AST printer and comparing the resulting AST of the generated source code against the original code's AST. This comparison is made through the json representation.
(The workflow currently fails but i am currently developing a fix for this)