XMI - tempo change

[psi29a]

@chrisisonwildcode said "Noticed that xmidi.c only uses the first tempo change and ignores all others. Issue?"

Do we have example VMI files that change tempo?

Could this have anything to do with this issue: #107
^-- Relates to converted types (mt32-to-GM/GS) "This is only suitable for music that doesn't do timbre changes XMIDIs that contain Timbre changes will not convert properly. "

[chrisisonwildcode]

The "Timbre" is throwing me off ... I think what they are referring to is that the xmi files have patch settings outside of the MIDI data (although in my tests the MIDI data also contained patch settings) ... so I speculate that its something to do with those, however because all the XMI's I tested contained patch information in the MIDI data, I ignored the patch settings outside of the MIDI data. If it later becomes an issue I can fix.

If we ever do find a xmi with tempo change, the player and associated dump (pressing 'm' while playing) will honour the tempo change, however the converter in xmidi.c which is used when you convert without playing will not.

[chrisisonwildcode]

Based on recorded in game audio and the finding of an XMI with a tempo change within it, -updates now only uses the first tempo setting within an XMI and ignores all others. This now matches the behaviour of the xmidi.c code when it comes to tempo changes.

Going to close this as the original reason for ticket is now sorted.