Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While thinking about the values to choose for PR 188, I thought I might want to take a look at the elevation distribution of a world. So I added some code to generate a hypsographic curve of the world.
Data corresponding to this PR can be found here.
Example for the test-world (28070):
image removed because it was ugly
The y-axis shows the different heights (all heights are occupied!), x shows the percentage - exactly as in the link about the hypsographic curve I gave above.
A couple of things can be seen:
It would probably be interesting to take a look at this plot right as the heightmap comes out of Platec. Aside from that I hope to finally find good values for PR 188 - if somebody can give hints, please do so.
EDIT: This also shows that we shouldn't just "fill up" the ocean to an arbitrary value after Platec generated the world making use of a very specific ocean-level. If the ocean_level variable is to be repaired, it should tie into Platecs generation.
EDIT2:
A slightly improved plot - there is a vertical line every ten percent now and a horizontal line for the different height thresholds (sea, plains, hills):
Here what it would look like after #188, the thresholds from bottom to top being sea, plains, hills, low mountains, medium mountains, high mountains: