Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query syntax revamp, perf improvements #100

Merged
merged 14 commits into from
Mar 13, 2024
Merged

Query syntax revamp, perf improvements #100

merged 14 commits into from
Mar 13, 2024

Conversation

0ffz
Copy link
Member

@0ffz 0ffz commented Feb 25, 2024

  • Use separate objects to define query types, then builder syntax for runners
  • Support anonymous objects nicely in the new syntax
  • Disallow modifications while iterating, (still possible via unsafeEntity but no longer supported by accessors)
    • Preferred alternative is the new defer { ... }.onComplete { ... } syntax for systems, listeners still allow live modifications
    • This simplifies some internal code and removes the need for things like removable
  • Performance improvements for iteration speed by switching up how accessors do their caching, as well as from simpler code disallowing modifications on iteration.
  • Update/reimplement some old tests (ex. for .map .orDefault) accessors
  • Update all addons, tests, and benchmarks to use the new syntax

@0ffz 0ffz changed the base branch from master to develop March 13, 2024 00:19
@0ffz 0ffz merged commit 018b0b7 into develop Mar 13, 2024
1 check passed
@0ffz 0ffz deleted the better-queries branch March 13, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant