Code clean #13
Open
Code clean #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireInstall
force-pushed
the
upstreamClean
branch
from
124bdc6
to
f6151a3
Compare
|
Rebase onto master. |
Phoenix616
requested changes
Sep 2, 2024
There was a problem hiding this comment.
Sorry for not getting to this earlier, it kinda slipped my mind. It should be okay overall but please remove the new Lombok usage. Lombok will not be used in the long-term due to it being a flawed approach in most cases (especially if it's just for getters/setters/data classes) and brings more issues than it usually solves.
src/main/java/de/minebench/syncinv/messenger/PlayerDataQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/de/minebench/syncinv/messenger/VersionMismatchException.java
Outdated
Show resolved
Hide resolved
FireInstall
force-pushed
the
upstreamClean
branch
from
48b3e14
to
06e852a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the Noise to it's own PR.