Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Develop #102

Merged
merged 32 commits into from
Nov 28, 2023
Merged

Develop #102

merged 32 commits into from
Nov 28, 2023

Conversation

tjdtn0219
Copy link
Contributor

@tjdtn0219 tjdtn0219 commented Nov 28, 2023 •
edited by laigasus
Loading

변경사항

3차 오픈

체크리스트

리뷰 요청 전에 확인해야 할 사항들을 나열해주세요.

  • 내 코드를 스스로 검토했나요?
  • 핵심 기능에 대해 충분한 테스트를 수행했나요?

tjdtn0219 and others added 30 commits November 28, 2023 03:55
@tjdtn0219
Fix: ReservationService bringAccommodation 변경 적용
cc91bc1
@tjdtn0219
Merge branch 'feature/#77-cart-exception' of https://github.com/Mini-…
fbf72be 
…Team-6/Mini-Team-6-Backend into feature/#86-reservation-refact
@tjdtn0219
Cart*Reservation tourAPIService 수정 반영
f1c31d6
@yuhyun1
Fix: 바뀌어야 하는 로직 주석 처리
57e1d34
@yuhyun1
Refactor: 사용하지 않는 메서드, import 삭제
cf3ac2c
@ypd06021
Fix: delete 메서드, 예외처리 수정
c95751c
@yuhyun1
Test: RoomController와 RoomService의 로직 변경으로 인한 기존 로직 삭제 및 바뀐 로직 반영한 테스…
7b5a696 
…트 코드 작성
@tjdtn0219
Fix: ReservationRoomDTO 시간 검증 어노테이션 변경
08619ea
@tjdtn0219
Resolve Conflict
3b52f59
@yuhyun1
Fix: 메소드명 변경
5e64b9b
@ypd06021
Fix: createRequest 체크인 체크아웃 데이터포맷 변경 (yyyy-mm-dd)->(yyyymmdd)
e9c0f7c
@ypd06021
Merge pull request #95 from Mini-Team-6/feature/#52-cart-test
503cd87 
Fix: delete 메서드, 예외처리 수정
@yuhyun1
Test: 숙소 테스트 코드 작성
c3bfad7
@laigasus
Feat: TourAPI exception 추가
00805a2
@yuhyun1
Merge pull request #97 from Mini-Team-6/feature/#93-exception-and-ref…
33868ea 
…actor

Feature/#93 리팩토링 및 테스트 코드 작성
@laigasus
Chore: TourAPI exception 안쓰는 것 삭제
9c54b47
@laigasus
Feat: TourAPI error message 추가
d5ea622
@laigasus
Feat: TourAPI error handler 추가
170f3cc
@laigasus
Feat: TourAPI 예외 로직 구현
50f45c9
@laigasus
Chore: xml 라이브러리 추가
4da315d
@ypd06021
Merge branch 'feature/#86-reservation-refactor' of https://github.com…
4d0293a 
…/Mini-Team-6/Mini-Team-6-Backend into feature/#52-cart-test
@tjdtn0219
Merge pull request #99 from Mini-Team-6/feature/#98-setup-tourapi-exc…
802ec67 
…eption

Feature/#98 setup tourapi exception
@tjdtn0219
Merge pull request #94 from Mini-Team-6/feature/#86-reservation-refactor
b2cdebb 
Feature/#86 reservation refactor
@ypd06021
Merge branch 'feature/#98-setup-tourapi-exception' of https://github.…
3d612ca 
…com/Mini-Team-6/Mini-Team-6-Backend into feature/#52-cart-test
@yuhyun1
Feat: 조회할 값이 없는 페이지 조회 시 204 에러처리
9d01579
@ypd06021
Fix: cart 체크인체크아웃 데이터 포맷 변경으로 인한 validation 및 예외처리 추가
4caeb87
@yuhyun1
Merge pull request #100 from Mini-Team-6/feature/#93-accommodation-ex…
c7e942d 
…ception

Feat: 조회할 값이 없는 페이지 조회 시 204 에러처리
@ypd06021
Fix: reservation 데이터 포맷 변경
4098ac9
@ypd06021
Fix: reservation 테스트 오류 수정
4886c2a
@ypd06021
Merge branch 'develop' of https://github.com/Mini-Team-6/Mini-Team-6-…
1a26458 
…Backend into feature/#52-cart-test
@tjdtn0219 tjdtn0219 added the enhancement New feature or request label Nov 28, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Test Results

23 tests  +4   23 ✔️ +4   1s ⏱️ ±0s
  9 suites +2     0 💤 ±0 
  9 files   +2     0 ❌ ±0 

Results for commit 885197b. ± Comparison against base commit 0d221b5.

This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both. 
ybe.mini.travelserver.domain.room.repository.RoomRepositoryTest ‑ 객실 단건 조회
ybe.mini.travelserver.domain.room.repository.RoomRepositoryTest ‑ 객실 단건 조회 - 존재하지 않는 경우
ybe.mini.travelserver.domain.room.service.RoomServiceTest ‑ 객실 상세 조회

ybe.mini.travelserver.domain.accommodation.controller.AccommodationControllerTest ‑ 숙소 리스트 조회
ybe.mini.travelserver.domain.accommodation.controller.AccommodationControllerTest ‑ 숙소 상세 조회
ybe.mini.travelserver.domain.accommodation.service.AccommodationServiceTest ‑ 숙소 리스트 조회
ybe.mini.travelserver.domain.accommodation.service.AccommodationServiceTest ‑ 숙소 상세 조회
ybe.mini.travelserver.domain.reservation.service.ReservationServiceTest ‑ createReservation_success()
ybe.mini.travelserver.domain.room.controller.RoomControllerTest ‑ 객실 리스트 조회 - Controller 테스트
ybe.mini.travelserver.domain.room.service.RoomServiceTest ‑ 객실 리스트 조회 - Service 테스트

♻️ This comment has been updated with latest results.

ypd06021
ypd06021 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ypd06021 ypd06021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@laigasus laigasus self-requested a review November 28, 2023 10:44
laigasus
laigasus approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@laigasus laigasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

변경사항 중 잠재된 기능결함은 없어보입니다!
마지막 코드 다듬을 때 참고하셔야 할 부분 댓글 남겼습니다!

src/main/java/ybe/mini/travelserver/domain/reservation/service/ReservationService.java Show resolved Hide resolved
...ain/java/ybe/mini/travelserver/domain/reservation_room/dto/ReservationRoomCreateRequest.java Show resolved Hide resolved
@laigasus laigasus merged commit 0086208 into main Nov 28, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laigasus laigasus laigasus approved these changes

@ypd06021 ypd06021 ypd06021 approved these changes

Assignees

@tjdtn0219 tjdtn0219

@ypd06021 ypd06021

Labels
enhancement New feature or request
Projects
미니 프로젝트 6조 백엔드
Status: Done
Milestone
Domain, Global 영역 예외처리
Development

Successfully merging this pull request may close these issues.
4 participants
@tjdtn0219 @laigasus @ypd06021 @yuhyun1