Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Feat: 객실 조회시 날짜 별 잔여 재고 반환 #107

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Feat: 객실 조회시 날짜 별 잔여 재고 반환 #107

merged 2 commits into from
Nov 29, 2023

Conversation

tjdtn0219
Copy link
Contributor

변경사항

변경사항에 대해 간략하게 설명해주세요.
SemVer 규칙을 따라야 합니다

Issue Link - #1

체크리스트

리뷰 요청 전에 확인해야 할 사항들을 나열해주세요.

  • 내 코드를 스스로 검토했나요?
  • 핵심 기능에 대해 충분한 테스트를 수행했나요?
  • 분석이 필요한가요?
  • 이것이 제품 업데이트의 일부인가요? 그렇다면, 이 업데이트에 대해 한 문장으로 작성해주세요.

날짜 별 잔여 재고 반환 로직 추가

@tjdtn0219 tjdtn0219 added the enhancement New feature or request label Nov 29, 2023
@tjdtn0219 tjdtn0219 self-assigned this Nov 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

Test Results

23 tests  ±0   23 ✔️ ±0   1s ⏱️ ±0s
  9 suites ±0     0 💤 ±0 
  9 files   ±0     0 ❌ ±0 

Results for commit 90ab4df. ± Comparison against base commit 701fdc5.

♻️ This comment has been updated with latest results.

yuhyun1
yuhyun1 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@yuhyun1 yuhyun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/main/java/ybe/mini/travelserver/domain/room/controller/RoomController.java Outdated
List<RoomGetResponseFromAPI> rooms = roomService.bringRoomsFromAPI(accommodationId);
public ResponseDto<List<RoomGetResponseFromAPI>> getRooms(
@PathVariable Long accommodationId,
@RequestParam String checkIn,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value = "check-in" 넣어주세요오

laigasus
laigasus approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@laigasus laigasus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공통 컴포넌트 관점 기준 잠재된 문제는 없어보입니다.

단. 장바구니, 예약 부문 시간 처리 요소가
합의된 것으로(@ypd06021) 알고 있어

향후 리팩터링에서 체크인, 체크아웃은
공통 엔티티, DTO 로 통일해도 괜찮을 것으로 보입니다.

@tjdtn0219 tjdtn0219 merged commit 9512b14 into develop Nov 29, 2023
3 checks passed
@laigasus laigasus mentioned this pull request Nov 29, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laigasus laigasus laigasus approved these changes

@yuhyun1 yuhyun1 yuhyun1 approved these changes

Assignees

@tjdtn0219 tjdtn0219

Labels
enhancement New feature or request
Projects
미니 프로젝트 6조 백엔드
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjdtn0219 @laigasus @yuhyun1