Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Develop #113

Merged
merged 13 commits into from
Nov 29, 2023
Merged

Develop #113

merged 13 commits into from
Nov 29, 2023

Conversation

tjdtn0219
Copy link
Contributor

@tjdtn0219 tjdtn0219 commented Nov 29, 2023

변경사항

4차 오픈


체크리스트

리뷰 요청 전에 확인해야 할 사항들을 나열해주세요.

  • 내 코드를 스스로 검토했나요?
  • 핵심 기능에 대해 충분한 테스트를 수행했나요?

laigasus and others added 12 commits November 29, 2023 16:44
`+` 다른 회원 제어시 오류 추가
`#` DeleteRequest(email)
`#` DeleteResponse(email, name)
`#` UpdateRequest(password, name)
`#` 토큰으로 인증처리된 회원의 데이터만 제어할 수 있음
`#` MemberService 에서 변경된 내용 반영
`#` API 오류는 사용자에게는 여행 백엔드 서버의 문제로 띄우도록 변경(5xx)
`-` 하드 코딩된 키를 지움
`+` 해당 API 키 장애 발생시 다른 키를 사용되도록 설계
…k-validation

Feat: 예약 시 이미 품절된 객실 검증 로직 추가
@laigasus laigasus added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Nov 29, 2023
Copy link

github-actions bot commented Nov 29, 2023

Test Results

23 tests  ±0   23 ✔️ ±0   1s ⏱️ ±0s
  9 suites ±0     0 💤 ±0 
  9 files   ±0     0 ±0 

Results for commit 111fd14. ± Comparison against base commit 9413794.

♻️ This comment has been updated with latest results.

Copy link
Member

@laigasus laigasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@laigasus laigasus merged commit 2f6cea6 into main Nov 29, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants