Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Feature/#98 setup tourapi exception #99

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

laigasus
Copy link
Member

@laigasus laigasus commented Nov 28, 2023

변경사항

예외 처리 구현

Issue Link - #98


체크리스트

리뷰 요청 전에 확인해야 할 사항들을 나열해주세요.

  • 공공포털에서 예외 발생시 XML 에 대한 오류를 핸들링했나요?
  • 숙소, 객실 조회가 0 일때 이에 따른 메시지 처리를 했나요?

참고

image
image
image

@laigasus laigasus added the documentation Improvements or additions to documentation label Nov 28, 2023
@laigasus laigasus self-assigned this Nov 28, 2023
@laigasus laigasus closed this Nov 28, 2023
@laigasus laigasus reopened this Nov 28, 2023
@laigasus laigasus changed the base branch from main to develop November 28, 2023 09:33
@laigasus laigasus added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Nov 28, 2023
Copy link

Test Results

19 tests  ±0   19 ✔️ ±0   1s ⏱️ ±0s
  7 suites ±0     0 💤 ±0 
  7 files   ±0     0 ±0 

Results for commit 4da315d. ± Comparison against base commit 9c84a29.

@@ -26,7 +26,7 @@ public Accommodation bringAccommodation(

var body = accommodationsSimpleSearchResponse.response().body();

if (body.totalCount() == 0) {
if (body.numOfRows() == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주 잘 캐치하셨네요!!

@tjdtn0219 tjdtn0219 merged commit 802ec67 into develop Nov 28, 2023
4 checks passed
@laigasus laigasus linked an issue Nov 28, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

[REQ] TourAPI 예외처리
3 participants