Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multi-instances #398

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

mrjk
Copy link
Contributor

@mrjk mrjk commented Dec 5, 2024

I'm proposing this PR to support multi-instances of nautilus-backup. I don't know if the implementation please you. So far, in other projects, there are two main way to accomplish this:

  • Use a different label prefix
  • Set a new option to filter only containers that match a key

I choose the first one, to avoid confusion since there is already an existing group option. This PR is complete, excepted tests are missing. I can eventually spend some time on writing them if you agree on the general implementation. Otherwise, feel free to make suggestions.

On my side, I'm already running nautical-backup with this patch on my infra, and it is working as expected.

@Minituff
Copy link
Owner

Minituff commented Dec 6, 2024

I like this @mrjk. Bonus points for updating the docs!!

I can see if I can get this merged in soon. Looks like I only need to update the formatting to get the tests to pass. I might add some unit tests as well.

Feel free to add that as well to speed up the process :)

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.87%. Comparing base (eea99fd) to head (d6c7ebb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   90.83%   90.87%   +0.04%     
==========================================
  Files           9        9              
  Lines         884      888       +4     
==========================================
+ Hits          803      807       +4     
  Misses         81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrjk
Copy link
Contributor Author

mrjk commented Dec 10, 2024

Ok, fixed the black issue.

I should really setup your project dev environment, but I'm not (yet) familiar with devcontainers, and last time I tried, setup was very slow, and seems to be stuck somewhere. Also, documentation is not totally clear on that topic. I'll try to update the doc when I'll have success with devcontainers ;)

About unit tests, I'm very bad at it, but I'll try to come with something tho; but I've quite limited time resources right now.

@Minituff Minituff merged commit 0222f30 into Minituff:main Dec 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants