This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
adding a surface observer interface #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-g
commented
Jun 30, 2021
erlend-g
commented
- Adding interface surface observer interface
- Adding a wrapper for Surface
AlanGriffiths
suggested changes
Jul 8, 2021
| void window_resized_to(mir::scene::Surface const* surf, mir::geometry::Size const& window_size) override; | ||
|
|
||
| private: | ||
| std::shared_ptr<miroil::SurfaceObserver> listener; |
| int query(MirWindowAttrib attrib) const; | ||
|
|
||
| private: | ||
| std::shared_ptr<mir::scene::Surface> wrapped; |
|
|
||
| private: | ||
| std::shared_ptr<mir::scene::Surface> wrapped; | ||
| std::unordered_map<std::shared_ptr<miroil::SurfaceObserver>, std::shared_ptr<miroil::SurfaceObserverImpl>> observers; |
There was a problem hiding this comment.
Shouldn't access to this be protected by (at least) a mutex?
It is probably best to copy the SurfaceObservers implementation (by using BasicObservers<> to achieve threadsafety.)
For a discussion about this design context see https://accu.org/journals/overload/22/124/griffiths_2040/ Some of the names have changed, and some of the code moved, but the design is the same. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.