New plugin: Fidor Bank AG #1
Conversation
| lines = f.readlines() | ||
| parser = FidorBankAGParser(lines) | ||
| parser.statement.account_id = self.settings['account'] | ||
| parser.statement.bank_id = self.settings.get('bank', '50050201') |
There was a problem hiding this comment.
This default 50050201 does not make sense with Fidor Bank, it's the BLZ from 1822direkt
There was a problem hiding this comment.
For Fidor, looks like it is 70022200
|
|
||
| Some other config options you may set are: | ||
|
|
||
| * *bank* (default: 50050201) |
There was a problem hiding this comment.
shouldn't be de default for Fidor, this is the BLZ from 1822direkt
| @@ -0,0 +1,91 @@ | |||
| ~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ofxstatement-fidorbank UPDATE THIS README | |||
There was a problem hiding this comment.
Can you please remove/update this "UPDATE THIS README"
There was a problem hiding this comment.
It's already been updated so this is safe to remove
| ===== | ||
|
|
||
| .. code:: bash | ||
| ofxstatement convert -t fidorbank umsaetze-0123456789-03.02.2018_15_05.csv test.ofx |
There was a problem hiding this comment.
Is this is default filename for CSV files downloaded from Fidor? I would like to keep the names of the files realistic.
There was a problem hiding this comment.
No, it's e.g. 2018-05-26-164912-Fidorpay-Transaktionen.csv
| # first element for the Payee. | ||
| desc_parts = beschreibung2.split(",") | ||
| desc1_parts = ("" + desc_parts[0]).split(":") | ||
| sl.payee = ("" + desc1_parts[1]).strip() |
There was a problem hiding this comment.
Why adding the empty string here?
There was a problem hiding this comment.
I'm not that experienced in Python, and I wanted PyCharm's code hints to work properly. So type coercion, basically.
germany_fidorbank/README.rst
Outdated
|
|
||
| Edit config. The *account* is the ID used by your accounting program to | ||
| associate the transactions with a certain account. Probably you want to use | ||
| your bank account number (Kontonummer) i.e. the last 10 digits of your IBAN. | ||
| (Note: YNAB does not seem to care about this field, since you import directly | ||
| to the account screen anyway.) |
There was a problem hiding this comment.
At least in classic YNAB, you can import a file by starting YNAB with this file as an argument. This is what my import process is doing. It then uses the account data to find out into which of the YNAB accounts it should import this file.
There was a problem hiding this comment.
I'm using this with the web version of YNAB, so less relevant. It might still do this from the All Accounts screen, but I haven't tried.
|
That's for classic, but I use the web version which also takes OFX imports.
…On Sat, May 26, 2018, 22:18 Mirko Dziadzka ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In germany_fidorbank/README.rst
<#1 (comment)>
:
>
Edit config. The *account* is the ID used by your accounting program to
associate the transactions with a certain account. Probably you want to use
your bank account number (Kontonummer) i.e. the last 10 digits of your IBAN.
+(Note: YNAB does not seem to care about this field, since you import directly
+to the account screen anyway.)
At least in classic YNAB, you can import a file by starting YNAB with this
file as an argument. This is what my import process is doing. It then uses
the account data to find out into which of the YNAB accounts it should
import this file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVANPSG0SaZnVRwlp4rYlNx84Ypa5MHks5t2biagaJpZM4UPCJa>
.
|
|
Here's a test CSV: |
|
SonarCloud Quality Gate failed.
|
Luckily, their CSV is rather organized. There are only four columns and two formats for these.
I used string-splitting and regular expession parsing to extract the Payee, and the rest of
the data was straightforward. I based this off the 1822direkt plugin.
Hope somebody finds it useful.