bottle reader unit test #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChasonSmith
added
vision
cjhr95
requested changes
Apr 3, 2024
| import json | ||
| import os.path | ||
| from typing import TypedDict | ||
| import unittest |
There was a problem hiding this comment.
The unittest package isn't currently in the poetry environment for the SUAS2023 repo. Is it necessary for the test's functionality, or can the file run without the package?
Comment on lines
+15
to
+17
|
|
||
| "test file exists" | ||
|
|
There was a problem hiding this comment.
Class needs a more descriptive docstring
|
|
||
| "test file exists" | ||
|
|
||
| def test_bottle_file(self) -> None: |
There was a problem hiding this comment.
function needs a numpy-style docstring
Comment on lines
+24
to
+26
| """ | ||
| make sure bottle list has what it should in it | ||
| """ |
There was a problem hiding this comment.
This could be moved into the function docstring
| make sure bottle list has what it should in it | ||
| """ | ||
|
|
||
| def test_bottle_read(self) -> None: |
There was a problem hiding this comment.
Numpy docstring for this function as well
eblake003
requested changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains the code for the bottle reader unit test