Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added openAPI for 3.0 #145

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Oct 25, 2024

Closes #144
Added the openAPI file for GBFS 3.0

@jcpitre jcpitre linked an issue Oct 25, 2024 that may be closed by this pull request
@@ -0,0 +1,201 @@
---
openapi: 3.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swagger seems to be having a strange issue with validating 3.1.0 swagger-api/swagger-editor#4798. If you input the openapi.yml at https://editor.swagger.io/ it will give you an error. Unless there is a major reason to use 3.1.0 we should use 3.0.3 like in the v2.3 openapi

Copy link
Contributor Author

@jcpitre jcpitre Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swaggerhub does not seem to have this problem, but there is no major reason for the change. I'll revert

Copy link
Contributor

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmambd emmambd requested a review from richfab October 28, 2024 19:05
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙏

@jcpitre jcpitre merged commit c592c20 into master Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenAPI schema for GBFS v3.0 version
4 participants