Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added libs+playground #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

basilstotz
Copy link

Hi,

I added blocks and aesl-generators for the native libs of thymio. Here you find a playground with my addition:

https://amxa.ch/blockly/tests/playground.de.html

Strange: I had to revert commit

basilstotz@577409e#diff-5c2a14051a1c0d43c8caaf804e33955d

to get the arguments with arrays working!

It not meant, that my commits goes streight to the code: It will need some tidy up before it can be used!

Basil

@stephanemagnenat
Copy link

Thank you for your contributions! @mbonani and @cbarraud , could you please test Basil's playground?

I do not understand why math is splitted into I and II, and what is the rationale for deciding which function goes where?

@basilstotz tell me when you think that the library is ready to be merged on your side. Also, I suggest that you announce the ongoing work on the aseba-dev mailing list, as the more people test the better.

@mbonani
Copy link

mbonani commented Jan 10, 2017

Thank you Basil for the contribution
For me it is also strange to have math I and math II,

The generated code seems correct.
What it is strange for me is that the blocks are mostly the direct implementation of the generated code. Should it be more phrasing, like

"find the min of array "value" and put result in "value"

to be more consistent with the blockly philosophy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants