diff --git a/src/schemas/units/heroes.ts b/src/schemas/units/heroes.ts index 40422aa..fb5bdfd 100644 --- a/src/schemas/units/heroes.ts +++ b/src/schemas/units/heroes.ts @@ -155,7 +155,7 @@ const baseHero = () => .field('RequiresSetup', s.int().min(0)), ), ) - + .field('showcase_attachments', s.obj().rest(s.int(), 'string')) .field('HUD', s.anything()) .field('Adjectives', s.obj().rest(s.int(), 'string')) diff --git a/test/schemas/abilities.ts b/test/schemas/abilities.ts index e252c0c..f972a54 100644 --- a/test/schemas/abilities.ts +++ b/test/schemas/abilities.ts @@ -8,23 +8,10 @@ describe('integration', () => { url: 'https://raw.githubusercontent.com/dotabuff/d2vpkr/master/dota/scripts/npc/npc_abilities.txt', ignore: [ - 'enigma_demonic_conversion.AbilityBehavior[0] should be a AbilityBehavior enum but is: DOTA_ABILITY_BEHAVIOR_POINT_TARGET', // Should be: DOTA_ABILITY_BEHAVIOR_POINT - 'arc_warden_tempest_double.AbilityBehavior[0] should be a AbilityBehavior enum but is: DOTA_ABILITY_BEHAVIOR_POINT_TARGET', // Should be: DOTA_ABILITY_BEHAVIOR_POINT - 'earth_spirit_boulder_smash.AbilityUnitTargetFlag is unknown', // Should be AbilityUnitTargetFlags instead - 'lone_druid_true_form_battle_cry.AbilityBehavior[1] should be a AbilityBehavior enum but is: DOTA_ABILITY_TYPE_ULTIMATE', // DOTA_ABILITY_TYPE_ULTIMATE - 'lone_druid_savage_roar_bear.AbilityBehavior[2] should be a AbilityBehavior enum but is: ABILITY_NOT_LEARNABLE', // Should be: DOTA_ABILITY_BEHAVIOR_NOT_LEARNABLE - 'meepo_poof.AbilityBehavior[1] should be a AbilityBehavior enum but is: ', // Extra |, empty string ability behavior 'satyr_soulstealer_mana_burn.Modelscale is unknown', // Model scale is a unit flag? - 'tinker_keen_teleport.AbilityBehavior[2] should be a AbilityBehavior enum but is: DOTA_ABILITY_BEHAVIOR_NOASSIST', // DOTA_ABILITY_BEHAVIOR_NOASSIST - 'abyssal_underlord_portal_warp.AbilityBehavior[2] should be a AbilityBehavior enum but is: DOTA_ABILITY_BEHAVIOR_NOASSIST', // DOTA_ABILITY_BEHAVIOR_NOASSIST - 'medusa_mana_shield.RequiredLevel should be greater than 0', // Innate learnable ability, RequiredLevel is -1 - 'elder_titan_move_spirit.AbilityBehavior[1] should be a AbilityBehavior enum but is: DOTA_ABILITY_BEHAVIOR_POINT_TARGET', // DOTA_ABILITY_BEHAVIOR_POINT_TARGET, should be DOTA_ABILITY_BEHAVIOR_POINT_TARGET - 'special_bonus_unique_warlock_1.base_class is unknown', // Should be BaseClass instead - 'special_bonus_unique_warlock_3.base_class is unknown', // Should be BaseClass instead 'twin_gate_portal_warp.AbilityBehavior[2] should be a AbilityBehavior enum but is: DOTA_ABILITY_BEHAVIOR_NOASSIST', - `dawnbreaker_solar_guardian.SpellImmunityType should be a SpellImmunityType enum but is: SPELL_IMMUNITY_ENEMIES_YES\" -\t\t`, // trailing \ AND since it escapes value, newline with tabs carry over - 'dawnbreaker_solar_guardian.FightRecapLevel" is unknown', // trailing \ + 'black_dragon_splash_attack.AbilitySpecial.range.var_type is missing', + 'black_dragon_splash_attack.AbilitySpecial.damage_percent should be an object' ], });