Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ipynb as example for shake generation. #102

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Added ipynb as example for shake generation. #102

merged 6 commits into from
Jun 11, 2024

Conversation

Lucky-Armin
Copy link
Collaborator

June 11, 2023 ape

@galjos
Copy link
Collaborator

galjos commented Jun 11, 2024

@Lucky-Armin I don't see any notebook.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.82%. Comparing base (2283160) to head (910950c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files         125      125           
  Lines        5003     5003           
=======================================
  Hits         4294     4294           
  Misses        709      709           
Flag Coverage Δ
unittests 85.82% <ø> (ø)

@Lucky-Armin
Copy link
Collaborator Author

I have overlooked the .ipynb file in the commit due to the .gitignore settings....

@galjos galjos requested a review from 97gamjak June 11, 2024 14:35
@galjos
Copy link
Collaborator

galjos commented Jun 11, 2024

@Lucky-Armin would you be so kind an clear the output of the notebook.

@galjos
Copy link
Collaborator

galjos commented Jun 11, 2024

@97gamjak I see we have an error in the Pylint action.

@galjos galjos merged commit 7ca25d9 into MolarVerse:main Jun 11, 2024
4 of 5 checks passed
@97gamjak
Copy link
Collaborator

@galjos @Lucky-Armin

Please note for the next time this shouldn't be a merge to main... should be included in dev - this is not worth a new tag - therefore, merging to dev

@97gamjak
Copy link
Collaborator

@97gamjak I see we have an error in the Pylint action.

Yes, I know this error. It only appears on pullnrequests from forked branches. Probaboy because the bot has nonwrite permissions on such repos.

@97gamjak
Copy link
Collaborator

closes #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants