Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/beartype exceptions #41

Merged
merged 4 commits into from
May 7, 2024
Merged

Feature/beartype exceptions #41

merged 4 commits into from
May 7, 2024

Conversation

97gamjak
Copy link
Collaborator

@97gamjak 97gamjak commented May 6, 2024

RDF analysis module fully type checked for all user relevant functions

Now also logger is implemented in the whole module - no more exceptions or warns.warnings

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 84.84848% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 77.52%. Comparing base (3585a95) to head (199734c).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #41      +/-   ##
==========================================
+ Coverage   75.73%   77.52%   +1.79%     
==========================================
  Files         119      119              
  Lines        4237     4272      +35     
==========================================
+ Hits         3209     3312     +103     
+ Misses       1028      960      -68     
Flag Coverage Δ
unittests 77.52% <84.84%> (+1.79%) ⬆️
Files Coverage Δ
PQAnalysis/analysis/rdf/rdf_input_file_reader.py 80.00% <100.00%> (+0.83%) ⬆️
PQAnalysis/analysis/rdf/rdf_output_file_writer.py 35.71% <100.00%> (+11.71%) ⬆️
PQAnalysis/topology/selection.py 98.58% <100.00%> (ø)
PQAnalysis/traj/trajectory.py 100.00% <100.00%> (ø)
PQAnalysis/type_checking.py 75.00% <100.00%> (+7.43%) ⬆️
PQAnalysis/utils/units.py 100.00% <100.00%> (ø)
PQAnalysis/utils/custom_logging.py 75.49% <75.00%> (-1.05%) ⬇️
PQAnalysis/analysis/rdf/rdf.py 77.24% <80.88%> (+46.57%) ⬆️

Copy link
Contributor

github-actions bot commented May 7, 2024

PYLINT REPORT

Your code has been rated at 9.89/10 (previous run: 9.87/10, +0.02)

Full report

Raw metrics

type number % previous difference
code 6527 38.84 6473 +54.00
docstring 7783 46.32 7755 +28.00
comment 221 1.32 226 -5.00
empty 2273 13.53 2253 +20.00

Duplication

now previous difference
nb duplicated lines 0 0 0
percent duplicated lines 0.000 0.000 =

Messages by category

type number previous difference
convention 0 10 10
refactor 37 36 36
warning 7 8 8
error 0 0 0

Messages

message id occurrences
too-many-arguments 18
too-many-instance-attributes 10
fixme 7
too-many-locals 3
duplicate-code 2
too-many-statements 1
too-many-return-statements 1
too-many-branches 1
too-complex 1

@97gamjak 97gamjak merged commit 535095e into dev May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant