Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for release 1.8.0 #27

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Prep for release 1.8.0 #27

merged 4 commits into from
Dec 18, 2024

Conversation

SGenheden
Copy link
Contributor

@SGenheden SGenheden requested a review from CKannas December 16, 2024 12:17
CKannas
CKannas approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@CKannas CKannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok.
A couple of minor issues that we missed in internal and got transferred here too.
I think we should sync pre-commit config with the internal. And maybe run it for all files?

rxnutils/pipeline/actions/reaction_mod.py Show resolved Hide resolved
rxnutils/routes/base.py Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@SGenheden SGenheden merged commit 65e9809 into main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CKannas CKannas CKannas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SGenheden @CKannas