Docs classifier update #1030
Closed
Docs classifier update #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the conda create statement for the developer version was incorrect (it added the "env" argument unnecessarily) and didn't specify which python version to use. The newest python (3.11) has updates to the dataclasses module, which prevent the ROI class from working properly (in detection/stats.py) due to it's not being hashable.
state is returned as an integer (0 for unchecked, 2 for checked). When state is compared with `QtCore.Qt.Checked`, it always evaluates to False, because Qt.Checked is an enum, not an int. Processing state through QtCore.Qt.CheckState fixes this error and allows the user to toggle ROIs on and off
Following the discussion in issue MouseLand#709, I added an explanation to the docs that explains how to apply a new classifier.
|
Hey @landoskape, thanks for this contribution! I'm noticing that part of this pull request contains commits involving changes in #1029 that are later reverted in the last commit. Just to keep things cleaner, could you create a new pull request that only includes the commit 9d51827 that adds to the docs? |
Merged
|
Yes, of course! Sorry about that. The new clean PR is in #1056. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in issue #709, I added an explanation for how to apply a custom classifier to the documentation. I was having trouble figuring out how to do this, so I thought it would be nice to provide an explanation in the docs, rather than having users look through GitHub issues to figure it out.