Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade gradle 6.5 -> 8.2.1 #14

Merged
merged 7 commits into from
Sep 3, 2023
Merged

build: upgrade gradle 6.5 -> 8.2.1 #14

merged 7 commits into from
Sep 3, 2023

Conversation

keturn
Copy link
Member

@keturn keturn commented Jun 7, 2022

Relates to MovingBlocks/Terasology#5109
Relates to MovingBlocks/Terasology#4653

Contains

  • Updating gradle from 6.5 -> 8.2.1
  • Updating gradle's files for which became invalid

How to test

  • run gradlew build -> do we build JNBullet this way?
  • we could further test it in combination with Terasology (groovyw lib get JNBullet && gradlew jar game)

Remarks

Java 20 is not yet supported, see gradle/gradle#23488.

Closes #13

@jdrueckert jdrueckert requested a review from pollend July 12, 2023 18:37
@jdrueckert
Copy link
Member

@pollend I updated this and I'm not sure whether the commit that updates swig-src files should be in here or whether we're missing something in our gitignore? The files just auto-updated when I ran ./gradlew tasks 👀

@jdrueckert jdrueckert changed the title build: upgrade to gradle 6.9.2 (from 6.5) build: upgrade gradle 6.5 -> 6.8 Jul 12, 2023
@jdrueckert jdrueckert changed the title build: upgrade gradle 6.5 -> 6.8 build: upgrade gradle 6.5 -> 8.2 Jul 12, 2023
@pollend
Copy link
Member

pollend commented Jul 13, 2023

I thought there was some scripts to generate the updated classes.i ? if this works with the current version of Terasology I can't see why this won't hurt. I think for the lib sources it's coming from artifactory, did you try building it from cpp source?

@soloturn
Copy link

gradle-8.2.1 got released, better use that one?

@jdrueckert jdrueckert changed the title build: upgrade gradle 6.5 -> 8.2 build: upgrade gradle 6.5 -> 8.2.1 Jul 30, 2023
@jdrueckert
Copy link
Member

did you try building it from cpp source?

@pollend nope didn't... should I try that or do you think building in the Terasology context (by including it in the libs dir) would work and be sufficient?

@jdrueckert jdrueckert merged commit 25ba516 into master Sep 3, 2023
@jdrueckert jdrueckert deleted the build/gradle69 branch September 3, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

upgrade to gradle 6.9.x (prep for gradle 7.x)
6 participants