Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump gradle 6.9.2 -> 8.2 #9

Merged
merged 4 commits into from
Jul 30, 2023
Merged

build: bump gradle 6.9.2 -> 8.2 #9

merged 4 commits into from
Jul 30, 2023

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Jul 12, 2023 •
edited
Loading

Relates to MovingBlocks/Terasology#5109
Relates to MovingBlocks/Terasology#4653

Contains

  • Updating gradle from 6.9.2 -> 8.2
  • Updating gradle's files which became invalid

How to test

  • run gradlew build -> should build and run splash screen

Remarks

Java 20 is not yet supported, see gradle/gradle#23488.

@jdrueckert
Copy link
Member Author

Current error: > Could not set unknown property 'classifier' for task ':sourceJar' of type org.gradle.api.tasks.bundling.Jar.

@jdrueckert jdrueckert marked this pull request as draft July 12, 2023 17:49
@jdrueckert jdrueckert changed the title build: bump gradle to 8.2 build: bump gradle 6.9.2 -> 8.2 Jul 12, 2023
@jdrueckert jdrueckert marked this pull request as ready for review July 12, 2023 18:05
@jdrueckert jdrueckert merged commit 6fe10f1 into master Jul 30, 2023
@jdrueckert jdrueckert deleted the build/bump-gradle-to-8.2 branch July 30, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminAmos BenjaminAmos BenjaminAmos approved these changes

@DarkWeird DarkWeird Awaiting requested review from DarkWeird

Assignees

@DarkWeird DarkWeird

@BenjaminAmos BenjaminAmos

Labels
None yet
Projects
Revive Terasology
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdrueckert @BenjaminAmos @DarkWeird