Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade gradle 6.5 -> 8.2.1 #71

Merged
merged 6 commits into from
Sep 3, 2023
Merged

build: upgrade gradle 6.5 -> 8.2.1 #71

merged 6 commits into from
Sep 3, 2023

Conversation

keturn
Copy link
Member

@keturn keturn commented Jun 7, 2022

Relates to MovingBlocks/Terasology#5109
Relates to MovingBlocks/Terasology#4653

Contains

  • Updating gradle from 6.5 -> 8.2.1
  • Updating gradle's files for which became invalid

How to test

  • run gradlew build -> should build TeraNUI
  • we could further test it in combination with Terasology (groovyw lib get TeraNUI && gradlew jar game)

Remarks

Java 20 is not yet supported, see gradle/gradle#23488.

Closes #57

@keturn keturn added Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research labels Jun 7, 2022
@jdrueckert jdrueckert changed the title build: upgrade to gradle 6.9.2 (from 6.5) build: upgrade gradle 6.5 -> 8.2 Jul 12, 2023
Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds and still works with Terasology.

The new Gradle wrapper jar corresponds with Gradle 6.9.2.

@jdrueckert
Copy link
Member

@BenjaminAmos @skaldarnar should we backport this to release/v2.x and release/v1.x branches?

@jdrueckert
Copy link
Member

The new Gradle wrapper jar corresponds with Gradle 6.9.2.

How would I update this? Just find and copy-paste the 8.2.1 version of it? 🤔
Or is there some gradle command I can run so it updates it itself?

@jdrueckert jdrueckert changed the title build: upgrade gradle 6.5 -> 8.2 build: upgrade gradle 6.5 -> 8.2.1 Jul 30, 2023
@BenjaminAmos
Copy link
Contributor

Destination Sol is actually using a snapshot from the preview/v4.x-SNAPSHOT branch because of Gestalt 8. I can handle backporting to there. I do not believe that either the release/v1.x or the release/v2.x branch is used anywhere anymore.

@BenjaminAmos
Copy link
Contributor

The new Gradle wrapper jar corresponds with Gradle 6.9.2.

How would I update this? Just find and copy-paste the 8.2.1 version of it? 🤔 Or is there some gradle command I can run so it updates it itself?

You can use the gradlew wrapper command to update the wrapper itself. I linked to the release checksums page above just in-case somebody wished to verify that the wrapper jar was identical to the official wrapper.

@BenjaminAmos BenjaminAmos merged commit f4d681d into master Sep 3, 2023
@jdrueckert jdrueckert deleted the build/gradle69 branch September 3, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

upgrade to gradle 6.9.x (prep for gradle 7.x)
4 participants