Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description of engine:checkStyleMain to gradlew tasks output #823

Closed
mkienenb opened this issue Jan 15, 2014 · 2 comments · Fixed by #5261
Closed

add description of engine:checkStyleMain to gradlew tasks output #823

mkienenb opened this issue Jan 15, 2014 · 2 comments · Fixed by #5261
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Revive: Keep issue has been looked at and deemed potentially helpful for revive

Comments

@mkienenb
Copy link
Contributor

mkienenb commented Jan 15, 2014

I couldn't figure out the way to do this, so no patch, but if possible, we should add engine:checkStyleMain as an option from gradlew tasks.

Glancing at the source, it looks like it should be done with a description="" setting for the checkStyleMain tasks, but I couldn't find that task (and maybe I'm completely wrong anyway).

I'm guessing this is because checkStyleMain is a checkstyle plugin task and not a Terasology one, but I guess we could make something that calls checkStyleMain? checkstyle, all lowercase, would seem like an obvious choice.

@Cervator
Copy link
Member

Agreed - maybe the checkStyleMain task itself is undocumented and simply declaring it and including that description might be enough (default tasks just exist, then you can declare extras on top)

A tougher problem is the dynamic tasks (fetchModuleX etc) - I haven't found a working combination to have their descriptions listed somehow

Edit: From IRC it might be an idea to make fake tasks to document the dynamic tasks if we can't get their descriptions to show normally :D And maybe a link or two to Jenkins/GitHub for modules

@jdrueckert
Copy link
Member

checkstyle and pmd tasks by default are added to the "Other Tasks" group which is not shown in the output of gradlew tasks, only in the output of gradlew tasks --all. #5261 adds checkstyle and pmd tasks to the "verification" group instead, so they show up next to the spotbugs tasks. With this, their task description is also visible:

Verification tasks
------------------
check - Runs all checks.
checkstyleJmh - Run Checkstyle analysis for jmh classes
checkstyleMain - Run Checkstyle analysis for main classes
checkstyleTest - Run Checkstyle analysis for test classes
integrationTest - Runs integration tests (slow) tagged with 'MteTest' or 'TteTest', exclude tests tagged 'flaky'.
integrationTestFlaky - Runs integration tests tagged with 'flaky' and either 'MteTest' or 'TteTest'.
pmdJmh - Run PMD analysis for jmh classes
pmdMain - Run PMD analysis for main classes
pmdTest - Run PMD analysis for test classes
sonar - Analyzes project ':engine' and its subprojects with Sonar.
sonarqube - Analyzes project ':engine' and its subprojects with Sonar. This task is deprecated. Use 'sonar' instead.
spotbugsJmh - Run SpotBugs analysis for the source set 'jmh'
spotbugsMain - Run SpotBugs analysis for the source set 'main'
spotbugsTest - Run SpotBugs analysis for the source set 'test'
test - Runs the test suite.
testDist
testDistForLauncher - Validates locations in distForLauncher.
testDistZip - Validates locations in distZip.
unitTest - Runs unit tests (fast)

Merging #5261 will close this issue

@jdrueckert jdrueckert added the Revive: Keep issue has been looked at and deemed potentially helpful for revive label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Revive: Keep issue has been looked at and deemed potentially helpful for revive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants