Qa/engine tests #5178
Merged
Qa/engine tests #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soloturn
force-pushed
the
qa/engine-tests
branch
2 times, most recently
from
d14ec53 to
28d1db6
Compare
skaldarnar
reviewed
Dec 2, 2023
| @@ -49,16 +51,12 @@ public void assertBT(String tree, List<BehaviorState> result, List<Integer> exec | |||
| assertBT(tree, result, executed, true); | |||
| } | |||
|
|
|||
| public void assertBT(String tree, List<BehaviorState> result, List<Integer> executed, boolean step) { | |||
| public void assertBT(String tree, List<BehaviorState> result, List<Integer> executed, boolean ignoredStep) { | |||
There was a problem hiding this comment.
Why the rename to ignoredStep? If this parameter is not used, shouldn't we just remove it?
There was a problem hiding this comment.
it is called in the test:
assertBT(tree, result, executed, false);
assertBT(tree, result, executed, true);
i added a TODO to check the tests.
soloturn
force-pushed
the
qa/engine-tests
branch
from
8e7d7e4 to
7df69eb
Compare
skaldarnar
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qa engine-tests: some checkstyle, spotbugs, pmd.