-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: screen merge follow-ups #5241
Conversation
i do get a build error here, not sure what i am doing wrong:
tried to fix it, but i am not sure what one needs to select so that drop back is visible. |
yeah I must've messed/mixed up the import... GitHub codespaces is not working as well as Intellij when it comes to imports between Terasology and gestalt... also didn't test this yet, so I probably should've opened it as a draft, sorry about that - switching to draft state now. |
e385609
to
525036d
Compare
force pushed my commit with line lenght correct, there was a checkstyle warning. otherwise it builds and works - but i am am a little clueless what should be different from before - so would be cool if you start it once and clcik to the screen you wanted to see a difference? @jdrueckert ? |
525036d
to
f72b3c6
Compare
- add popup for user in case selected world generator cannot be resolved
f72b3c6
to
b08639b
Compare
@soloturn I listed the changes I've done in this PR in the description:
If you navigate to the universe setup screen (Singleplayer -> Create -> Advanced -> Continue to Universe Setup), and compare between develop and this branch, you should be able to notice the frist two aspects. The third one is only visible in-code and the fourth and fifth are indeed hard to test ...
|
if its hard to test, then lets merge it, and fix if somebody really notices a regression. |
Contains
How to test
Outstanding before merging