chore: introduce RemoteResource<T> interface
#712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added
Type: Enhancement
soloturn
reviewed
Nov 26, 2023
| /** | ||
| * @deprecated Use {@link DownloadUtils#download(RemoteResource, Path, ProgressListener)} instead. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
am lacking experience here, but the method is private. why deprecating it?
There was a problem hiding this comment.
Not sure whether it actually has any effect other than your IDE telling you this is deprecated 🤷 I kinda see it as a TODO to replace the call side of this method with what is written in the deprecation note.
That way, I don't change any interfaces now, and can make this change in a follow up PR to keep the PRs smaller.
There was a problem hiding this comment.
can we add a deprecation note to the upper one, too?
There was a problem hiding this comment.
There was only a single use of that other method, so I just inlined it and removed the method in 482ba65.
jdrueckert
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Both games and JREs will be "installed" and managed by the launcher in the future.
I believe that both can have a shared interface for the remote resource, that is, the download URL.
I'm not sure about other properties yet, like a checksum for the file. For managed JREs, the checksum will be statically known. For game releases, we can fetch the checksum separately from remote. Probably should also be a
Future<String>to express the async nature, or just aStringwith someIOException? 🤔Also start turning the static utility class
DownloadUtilsinto a class that can be instantiated. This should help long-term with testability of the different manager classes, and make it easier to make the timeouts configurable and testable.How to test
The changes should be a refactoring from the user's point of view.
Ensure that the launcher is working as before.
I've tested this on Windows by downloading a release and starting it.
Outstanding before merging
Nothing.