chore: restructure Platform
#714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminAmos
reviewed
Dec 3, 2023
Comment on lines
20
to
33
| //TODO(skaldarnar): I'm not fully settled on how to model the Platform. I thought splitting this up into two enums | ||
| // for OS and Architecture would help with more type-safe construction of these values, simplify comparison to | ||
| // select the right JRE for a game, etc. | ||
| // | ||
| // On the other hand, the set of supported platforms is so limited, and continuing on a non-supported platform | ||
| // does not make much sense. So, maybe it is better to have a rather restrictive and explicit enum in the form of | ||
| // WINDOWS_X64 | ||
| // LINUX_X64 | ||
| // I'm adding the architecture to this list, as I hope that we'll be able to support old Intel and new M1 Macs at | ||
| // some point in the future, adding the following to the list: | ||
| // MAC_X64 | ||
| // MAC_AARCH64 | ||
| // The biggest drawback of being super-strict here is that development on non-supported platforms becomes | ||
| // impossible where it was just "not ideal" before. |
There was a problem hiding this comment.
It think this should be as type-safe as possible. It shouldn't be possible to run the launcher on unsupported platforms unintentionally. Having seperate enums for OS and Architecture allows for greater flexibility in adding new platforms in the future and also makes it easier to significantly differentiate by OS alone where needed. You could also possibly make Platform itself an enum for further type safety.
skaldarnar
force-pushed
the
topic/restructure-platform-info
branch
from
11bb4a3
to
76ee046
Compare
skaldarnar
added
the
Type: Maintenance
BenjaminAmos
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Restructure the
Platformutility class and splits outOSandArchas separate enums.Loosely based on #708.
How to test
Nothing should change based on this PR.
Outstanding before merging
The feedback received sounded like we can can move forward with with this mostly as is. I've incorporated the idea of making
Platformand enum itself.