Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update burze_dzis_net.ts #202

Closed
wants to merge 1 commit into from
Closed

Update burze_dzis_net.ts #202

wants to merge 1 commit into from

Conversation

nepozs
Copy link
Contributor

@nepozs nepozs commented Jul 15, 2023

proposed changes should work with burze_dzis_net v2.0.0
it maybe could resolve issue #201

I've only changed entities suffixes of entity names, so it fixes only situation with main entities, but it maybe isn't enough? maybe also suffixes of friendly names should be modified?
And should be shorter, as now two variants each entity exist
…Ostrzeżenie - Burza
…Ostrzeżenie Aktywne - Burza

So could be tested only string "Burza" instead of "Ostrzeżenie - Burza"


There are also other changes in component burze_dzis_net maybe some of them could be used in the card?

proposed changes should work with burze_dzis_net v2.0.0
@MrBartusek
Copy link
Owner

MrBartusek commented Jul 15, 2023

it maybe could resolve issue

Yeah, you should setup project locally and test that for sure. Please see contributing guide and let me know if you encounter any issues

@nepozs
Copy link
Contributor Author

nepozs commented Jul 15, 2023

Sorry it is over my ability (I'm not a developer nor programmer at all), but I'm sure it should work (tested opposed way by change names of new entities).

and one word more: I've edited first post many times, so I'm not sure if you have read all.

Maybe you could publish beta version? (as you have well knowledge about the needed environment).

@nepozs nepozs marked this pull request as draft July 15, 2023 21:41
@MrBartusek
Copy link
Owner

Okay, I appreciate your try to help but from a quick glance i can see that it wont work, it doesn't modify supports function. You can just close this and i will work on fix in following days

@nepozs
Copy link
Contributor Author

nepozs commented Jul 15, 2023

Thanks a lot, issue and this pr took me whole day.

@nepozs
Copy link
Contributor Author

nepozs commented Jul 15, 2023

Once again thanks.

@nepozs nepozs closed this Jul 15, 2023
@nepozs nepozs deleted the patch-2 branch July 15, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants