Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for latest ensembles #349

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

sophiemiddleton
Copy link
Collaborator

Includes:

  • updates to ensembling scripts to allow for grid use
  • pion filters for RPC work

@FNALbuild
Copy link
Collaborator

Hi @sophiemiddleton,
You have proposed changes to files in these packages:

  • JobConfig
  • Scripts
  • /
  • CampaignConfig
  • Tests

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 97f4987: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@sophiemiddleton
Copy link
Collaborator Author

with Mu2e/Offline#1341

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 97f4987.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 97f4987 at a28b68d
build (prof) Log file. Build time: 04 min 14 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 97f4987 after being merged into the base branch at a28b68d.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@sophiemiddleton
Copy link
Collaborator Author

Any comments on this? I would like to start making RPC samples this week to make MDS-1

@brownd1978 brownd1978 self-assigned this Oct 1, 2024
Copy link
Collaborator

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should address the question about separate SimEfficiency tables for special runs (pion is one example) with database experts.

Scripts/CreateSimEfficiency.sh Outdated Show resolved Hide resolved
// Base configuration for prefiltering pions based on time
// original author: Sophie Middleton, 2024
//
#include "Production/JobConfig/primary/StopParticleFilter.fcl"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only place StopParticleFilter is used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently I think so

@sophiemiddleton
Copy link
Collaborator Author

Any more comments on this, it would be good to have it merged and tagged in a SimJob to use the python scripts that way

Copy link
Collaborator

@oksuzian oksuzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the suggestions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this script?
Why is it using hardcoded versions of eventCount, col1?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we moved to jitfcl?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems redundant.
Primaries are generated with CampaignConfig/mdc2020_primary.ini.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we don't use private includes in the Production repository.
I also propose a workflow that uses [global] in the prolog ONLY.
Having said that, I'm fine with the addition of this file. I will just need to adapt it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, are we still using _fcls?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use mdc2020_primary.cfg instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using the reference to a private code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants