-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for latest ensembles #349
base: main
Are you sure you want to change the base?
Conversation
Hi @sophiemiddleton,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 97f4987: build (Build queue is empty) |
with Mu2e/Offline#1341 |
☀️ The build tests passed at 97f4987.
N.B. These results were obtained from a build of this Pull Request at 97f4987 after being merged into the base branch at a28b68d. For more information, please check the job page here. |
Any comments on this? I would like to start making RPC samples this week to make MDS-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should address the question about separate SimEfficiency tables for special runs (pion is one example) with database experts.
// Base configuration for prefiltering pions based on time | ||
// original author: Sophie Middleton, 2024 | ||
// | ||
#include "Production/JobConfig/primary/StopParticleFilter.fcl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only place StopParticleFilter is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently I think so
Any more comments on this, it would be good to have it merged and tagged in a SimJob to use the python scripts that way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the suggestions
Scripts/removezero.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this script?
Why is it using hardcoded versions of eventCount, col1?
CampaignConfig/mdc2020_RPC.ini
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we moved to jitfcl?
CampaignConfig/mdc2024_DIOtail.ini
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems redundant.
Primaries are generated with CampaignConfig/mdc2020_primary.ini.
CampaignConfig/mdc2024_ensembles.cfg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we don't use private includes in the Production repository.
I also propose a workflow that uses [global] in the prolog ONLY.
Having said that, I'm fine with the addition of this file. I will just need to adapt it.
CampaignConfig/mdc2024_ensembles.ini
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, are we still using _fcls?
CampaignConfig/mdc2024_primary.cfg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use mdc2020_primary.cfg instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using the reference to a private code.
Includes: