Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2pchanges #5

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

P2pchanges #5

wants to merge 6 commits into from

Conversation

Harshita0008
Copy link

Updated config util, changes invoice and fixed issues.

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mugglelink-form ❌ Failed (Inspect) Mar 29, 2024 2:30pm

@@ -0,0 +1,39 @@
import { NextResponse } from "next/server";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the sendgrid code in mugglelink-form, and mlink-frontend?
They are duplicated. Can we make it once?
(Ideally in backend)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we have seperate email templates for both muggle form and mlink we should keep the email part seperated

});
quantity_max: z.string().min(1, { message: "Quantity is required" }),
quantity_min: z.string().min(1, { message: "Quantity is required" }),
enable_peer_to_peer: z.optional(z.boolean()),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look on the PR.
Can't you see the codes tabs?

@@ -1,6 +1,11 @@
import { type ClassValue, clsx } from "clsx"
import { twMerge } from "tailwind-merge"

export const apiPrefix =
process.env.NODE_ENV !== "production"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the apiPrefix as API_HOST_PREFIX in .env

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of manually changing environment variables every time we switch between development and production modes, we rely on a default variable called NODE_ENV. This variable automatically lets us know whether we're in development or production mode, allowing us to set variables accordingly without constant manual adjustments.

Copy link

@shawnmuggle shawnmuggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. just the apiPrefix as API_HOST_PREFIX in .env
  2. Styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants