-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2pchanges #5
base: main
Are you sure you want to change the base?
P2pchanges #5
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/app/api/sendgrid/route.js
Outdated
@@ -0,0 +1,39 @@ | |||
import { NextResponse } from "next/server"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the sendgrid code in mugglelink-form, and mlink-frontend?
They are duplicated. Can we make it once?
(Ideally in backend)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have seperate email templates for both muggle form and mlink we should keep the email part seperated
src/components/MerchantForm.tsx
Outdated
}); | ||
quantity_max: z.string().min(1, { message: "Quantity is required" }), | ||
quantity_min: z.string().min(1, { message: "Quantity is required" }), | ||
enable_peer_to_peer: z.optional(z.boolean()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look on the PR.
Can't you see the codes tabs?
@@ -1,6 +1,11 @@ | |||
import { type ClassValue, clsx } from "clsx" | |||
import { twMerge } from "tailwind-merge" | |||
|
|||
export const apiPrefix = | |||
process.env.NODE_ENV !== "production" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the apiPrefix as API_HOST_PREFIX in .env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of manually changing environment variables every time we switch between development and production modes, we rely on a default variable called NODE_ENV. This variable automatically lets us know whether we're in development or production mode, allowing us to set variables accordingly without constant manual adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- just the apiPrefix as API_HOST_PREFIX in .env
- Styles
Updated config util, changes invoice and fixed issues.