Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customtemplate for eduadmin-programme-detail #434

Open
pmerkland opened this issue Mar 23, 2022 · 5 comments
Open

Add support for customtemplate for eduadmin-programme-detail #434

pmerkland opened this issue Mar 23, 2022 · 5 comments

Comments

@pmerkland
Copy link
Collaborator

Something like [eduadmin-programme-detail customtemplate]

I guess it would be good if we can keep the same format for all the parts as on the detail page for courses like [eduadmin-detailinfo coursedescriptionshort], if not then we can do something like [eduadmin-programmeinfo coursedescriptionshort]

@pmerkland pmerkland changed the title Add support for customtemplate for programme-details Add support for customtemplate for eduadmin-programme-detail Mar 23, 2022
@pmerkland
Copy link
Collaborator Author

Might it even be an option to use the exact same detailview page och bookingview page for programme starts?

@itssimple
Copy link
Member

Might it even be an option to use the exact same detailview page och bookingview page for programme starts?

I'm not entirely sure what you mean by this. Do you mean using the normal course detail and booking view, or what are you proposing?

@pmerkland
Copy link
Collaborator Author

Might it even be an option to use the exact same detailview page och bookingview page for programme starts?

I'm not entirely sure what you mean by this. Do you mean using the normal course detail and booking view, or what are you proposing?

Yes, depending on how much work it would be. The data model is basically the same, some parameters have different names in the API though.

In the long run, we would probably save time as we don't have to maintain two almost identical copies of the pages.

OR we just develop support for custom template on the eduadmin-programme-detail page. Some of our customers already use a custom template for normal courses and want to do the same for programmes.

@itssimple
Copy link
Member

That would be a totally different issue though, from custom templates on programmes.
So, for merging the booking page, I'd recommend splitting that in a separate issue.

No feature creeping.

@pmerkland
Copy link
Collaborator Author

I agree but if we merge the pages this issue for the custom template for programmes becomes irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants