Fix test (current dps + exception on missing source of triggered skills)

Musholic · Apr 22, 2024 · b0e353e · b0e353e
1 parent ea7ecec
commit b0e353e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/spec/System/TestBuildImport_spec.lua b/spec/System/TestBuildImport_spec.lua
@@ -19,6 +19,6 @@ expose("BuildImport #buildImport", function()
 
         --TODO: Ignite dps, Blessing support
         assert.are.equals("Fireball", build.calcsTab.mainEnv.player.mainSkill.skillCfg.skillName)
-        assert.are.equals(5226, round(build.calcsTab.mainOutput.FullDPS))
+        assert.are.equals(4848, round(build.calcsTab.mainOutput.FullDPS))
     end)
 end)
diff --git a/src/Modules/CalcSetup.lua b/src/Modules/CalcSetup.lua
@@ -1414,7 +1414,7 @@ function calcs.initEnv(build, mode, override, specEnv)
 			end
 		end
 	end
-	if not GlobalCache.grantedTriggeredSkills or #GlobalCache.grantedTriggeredSkills < #grantedTriggeredSkills then
+	if not GlobalCache.grantedTriggeredSkills or #GlobalCache.grantedTriggeredSkills ~= #grantedTriggeredSkills then
 		GlobalCache.grantedTriggeredSkills = grantedTriggeredSkills
 		build.buildFlag = true
 	end

diff --git a/src/Modules/CalcTriggers.lua b/src/Modules/CalcTriggers.lua
@@ -814,6 +814,9 @@ local configTable = {
 				break
 			end
 		end
+		if not source then
+			return
+		end
 
 		-- The triggered skill inherits the source skill mods
 		calcs.mergeSkillInstanceMods(env, env.player.mainSkill.skillModList, source.activeEffect)