Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract backend storage #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dienummer
Copy link
Contributor

Initial abstraction with working Postgres and stub Rocksdb

TBD:

  • abstract startup (db connection intialization)
  • decide how to select backend in config

TBD:
 - abstract startup (db connection intialization)
 - decide how to select backend in config
@dienummer
Copy link
Contributor Author

dienummer commented Jan 25, 2024

Shoot I forgot to cargo fmt and to rip out the unused code in VssItem. I'll wait on comments before further commits

@benthecarman
Copy link
Contributor

How much do you need this? I'd rather not have to complicate the logic for this unless postgres is really a non-starter for people, which I don't see why it would be

@dienummer
Copy link
Contributor Author

How much do you need this? I'd rather not have to complicate the logic for this unless postgres is really a non-starter for people, which I don't see why it would be

Hey, thanks for taking a look. I don't need it, but it would be undoubtedly much more convenient to deploy a single binary or container with SQLite or Rocksdb as a backend.

Additionally, in my opinion this makes the logic less complicated (see put_objects_impl for instance), but reasonable people can disagree on this.

In any case, you may wish to leave this open until the server is more widely used, to get a sense of whether others also feel removing the postgres dependency eases deployment.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants