feat(rich-text-editor) - addition of link component #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-2981 |
github-actions
bot
requested review from
daragh-king-genesys and
thomas-c-dillon
| private root: HTMLElement; | ||
|
|
||
| @Prop() | ||
| disabled: boolean = false; |
There was a problem hiding this comment.
A question from UX was should we disable this link action until a piece of text is highlighted ? I
| @@ -178,6 +192,60 @@ <h2>No action divider</h2> | |||
| editor.commands.setParagraph(); | |||
| }) | |||
|
|
|||
| /* Link action */ | |||
| /* The code below is just an example and can be altered to your preference. */ | |||
There was a problem hiding this comment.
There may be betters ways to do this but the dev has full control of how they want it to work.
| const { Editor } = await import('https://cdn.jsdelivr.net/npm/@tiptap/core@2.2.2/+esm'); | ||
| const StarterKit = (await import('https://cdn.jsdelivr.net/npm/@tiptap/starter-kit@2.2.2/+esm')).default; | ||
| const Underline = (await import('https://cdn.jsdelivr.net/npm/@tiptap/extension-underline@2.2.2/+esm')).default; | ||
| const Heading = (await import('https://cdn.jsdelivr.net/npm/@tiptap/extension-heading@2.7.4/+esm')).default; |
There was a problem hiding this comment.
This was included in the starter kit so just removed this import.
daragh-king-genesys
approved these changes
Jan 8, 2025
adding extra functionality to link ✅ Closes: COMUI-2981
gavin-everett-genesys
force-pushed
the
feature/COMUI-2981
branch
from
72f25ae to
ce98a6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket : https://inindca.atlassian.net/browse/COMUI-2981