Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(other): update dependencies to wanted #813

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

daragh-king-genesys
Copy link
Collaborator

update dependencies to wanted

update dependencies to wanted
Copy link

github-actions bot commented Jan 7, 2025

@daragh-king-genesys
Copy link
Collaborator Author

This was the first dependency update in a while (2+ years) that I was able to use npm update --save instead of updating dependencies one at a time to not break our lock file.

Copy link
Collaborator

@321gillian 321gillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daragh-king-genesys I did a clean install locally, ran build/tests etc and read through the changelogs for the dependencies to see if there was anything unexpected there. Is that the right way to review this kind of change or would you have any other suggestions?

@daragh-king-genesys
Copy link
Collaborator Author

@daragh-king-genesys I did a clean install locally, ran build/tests etc and read through the changelogs for the dependencies to see if there was anything unexpected there. Is that the right way to review this kind of change or would you have any other suggestions?

The only other thing I do is make sure the time machine branch was created successfully and click around a bit on it to make sure there is nothing obviously broken

@daragh-king-genesys daragh-king-genesys merged commit a3df3c1 into main Jan 7, 2025
4 checks passed
@daragh-king-genesys daragh-king-genesys deleted the feature/20250107-dependency-update branch January 10, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants