feat(rich-text-editor): addition of text-highlight feature #852
Conversation
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-2987 |
|
This isn't relevant to this specific PR but in other rich text editors (Google Docs, Teams, Word, Jira etc) the left/right arrows are used to navigate through the options so it might be good to enable that as well for this one. |
...tor-action/gux-rich-text-editor-action-rich-style/gux-rich-text-editor-action-rich-style.tsx
Outdated
Show resolved
Hide resolved
...ich-text-editor-action/gux-rich-text-editor-action-link/gux-rich-text-editor-action-link.tsx
Show resolved
Hide resolved
...tor/gux-rich-text-editor-list/gux-rich-highlight-list-item/gux-rich-highlight-list-item.scss
Show resolved
Hide resolved
| <gux-tooltip> | ||
| <div slot="content">{this.i18n(`${this.highlight}`)}</div> | ||
| </gux-tooltip> |
There was a problem hiding this comment.
| <gux-tooltip> | |
| <div slot="content">{this.i18n(`${this.highlight}`)}</div> | |
| </gux-tooltip> | |
| <gux-tooltip-beta> | |
| <div slot="content">{this.i18n(`${this.highlight}`)}</div> | |
| </gux-tooltip-beta> |
...components/beta/gux-rich-text-editor/gux-rich-text-editor-list/gux-rich-text-editor-list.tsx
Outdated
Show resolved
Hide resolved
...components/beta/gux-rich-text-editor/gux-rich-text-editor-list/gux-rich-text-editor-list.tsx
Show resolved
Hide resolved
...components/beta/gux-rich-text-editor/gux-rich-text-editor-list/gux-rich-text-editor-list.tsx
Outdated
Show resolved
Hide resolved
|
I feel like maybe the keyboard navigation within the highlight list could be consistent so either tab to everything or arrow through everything. |
Created ticket for this 👍 |
wip of color picker feature ✅ Closes: COMUI-2987
gavin-everett-genesys
force-pushed
the
feature/COMUI-2987
branch
from
7f692ca to
84f18db
Compare
text-highlight feature.
I had a go at the keyboard accessibility let me know of any concerns you see.
✅ Closes: COMUI-2987