No jira: go checks #1163
Merged
No jira: go checks #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliecon
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12 and
kavinbalagen
as code owners
carnellj-genesys
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we'll be disabling the acceptance tests on GitHub soon, I think it would be a good idea to keep a workflow that checks the following:
go generatedoesn't change any filesgo mod tidydoesn't change any filesgo vet ./genesyscloud/...doesn't produce any outputI renamed the "Generate" job to "Go Checks" and added all the steps outlined above. Eventually, we can add the linter as well.