Revert "Inspired by DEVTOOLING-741 - Hardening E.164 handling" #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ceb1ad.
charliecon
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12 and
kavinbalagen
as code owners
dginty4
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1178
@bbbco I decided to revert this PR since I noticed that it affected some unit tests. I doubt there is anything wrong with you're work, but there are probably some tests that are expecting different behaviour when it comes to phone numbers.
I think we should get this release out, then merge your changes to dev, then catch all the broken test cases and get working on them before the next release (which I believe is next week)