NOJIRA - Fix/outbound route cache #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly bringing over caching logic from site resource
bbbco
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12,
charliecon,
kavinbalagen,
BrianMoyles and
sureshperiyappan
as code owners
dginty4
approved these changes
Jan 7, 2025
carnellj-genesys
approved these changes
Jan 12, 2025
charliecon
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug where the output of the outbound routes would return the same outbound routes as the previous site if the same number of routes was returned. This was discovered while testing telephony support for the BCP Wizard.
This caching logic was obviously copied over from the site resource, where it should remain. But it is not appropriate for this resource.
Also fixes an issue where a cache collision could occur (unlikely but important to address)