[Devtooling-672] Added Missing Attributes and Refactor #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianMoyles
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12,
charliecon,
kavinbalagen and
sureshperiyappan
as code owners
bbbco
reviewed
Jan 21, 2025
| proxy := newVariationRequestProxy(sdkConfig) | ||
|
|
||
| name := d.Get("name").(string) | ||
| knowledgeBaseID := d.Get("knowledge_base_id").(string) |
There was a problem hiding this comment.
Probably a good idea to use buildVariationId() and splitVariationId() functions to ensure consistency for handling.
| } | ||
|
|
||
| for _, knowledgeDocumentVariation := range *knowledgeDocumentVariations { | ||
| id := fmt.Sprintf("%s %s %s", *knowledgeDocumentVariation.Id, *knowledgeDoc.KnowledgeBase.Id, *knowledgeDoc.Id) |
There was a problem hiding this comment.
This has bugged the heck out of me whenever I've happened across this particular resource. The building of the ID is not consistent. It seems like it should be knowledge base ID + knowledge doc ID + knowledge variation ID to align with the hierarchy of the parent resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a Refactor of
Knowledge Document VariationIt incorporates the missing 'name' field, missing 'context' field and missing 'properties' field
It also resolves bugs found during the refactor.
Amazon Q was used to check for potential nil pointers, errors, etc