Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forcibly push the user to SettingsActivity from MainActivity #57

Open
Cliabhach opened this issue Sep 11, 2017 · 2 comments
Open
Assignees

Comments

@Cliabhach
Copy link
Collaborator

Cliabhach commented Sep 11, 2017

MainActivity::loadPreferences, when we don't have an IP address, automatically opens the settings screen (SettingsActivity). This means that if the user opens this app for the first time, they will be immediately pushed to SettingsActivity.

It also means that pressing back from SettingsActivity without having a valid stored IP address may cause this code to run, pushing the user forward into SettingsActivity. This occurs naturally on low-memory devices, and can be easily simulated by enabling the developer option Don't keep activities.

I suggest that we instead put a noticeable (but non-modal!) warning that the app is not fully configured, with a button to view app settings. Perhaps a SnackBar?

@Cliabhach
Copy link
Collaborator Author

May be linked to issue #54

@Cliabhach Cliabhach self-assigned this Sep 11, 2017
@seymour-bootay
Copy link
Collaborator

Lets disscuss this after i get my changes in. I am still forcing to settings but there is better feedback on the screen when the app is not configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants