singularize/pluralize #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
enhancement
Closed
devs-mycroft
added
the
CLA: Yes
requirements.txt
Outdated
| python-dateutil==2.6.0 | ||
| inflection |
There was a problem hiding this comment.
I think this should get a version tag, just in case of future bugs or licensing changes.
There was a problem hiding this comment.
this is also a single file, would it make sense instead to bundle it in lingua franca? the advantage would be for other languages to use as template
otherwise i agree that we should pin version number
JarbasAl
force-pushed
the
feat/plural_singular
branch
from
22143f9 to
3ea2fb1
Compare
5 tasks
|
to be rebased and integrated with #167 |
NeonJarbas
pushed a commit
to NeonJarbas/ovos-lingua-franca
that referenced
this pull request
Jul 13, 2022
NeonJarbas
pushed a commit
to NeonJarbas/ovos-lingua-franca
that referenced
this pull request
Jul 13, 2022
port MycroftAI#36 + MycroftAI#37 add pt pluralizations.json add tests
NeonJarbas
pushed a commit
to NeonJarbas/ovos-lingua-franca
that referenced
this pull request
Jul 13, 2022
port MycroftAI#36 + MycroftAI#37 add pt pluralizations.json add tests
emphasize
added a commit
to emphasize/lingua-franca
that referenced
this pull request
Feb 20, 2023
* fix inconsitency in nice_time_de * update nice_date_time test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35