Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to normalize comma-delimited decimals #67

Conversation

ChanceNCounter
Copy link
Contributor

Closes #65

All languages, including English, will now normalize 34,5 to 34.5 before beginning to extract numbers.

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jan 11, 2020
@ChanceNCounter
Copy link
Contributor Author

For those who don't speak regex, though I encourage you to run the regex through a regex tester, it means this:

.*\d+,{1}\d+:
.* anything, including nothing, followed by
\d+ any number of digits, followed by
,{1} exactly one comma, followed by
\d+ any number of digits

thought this was fixed in PR#62
@ChanceNCounter
Copy link
Contributor Author

aaaand i pushed a hotfix to the wrong branch. closing and fixing.

@ChanceNCounter ChanceNCounter deleted the normalize-decimal-numbers branch January 11, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract_number() functions need to convert '#,#' to float('#.#')
2 participants