Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/generalize vector ingest #83

Merged
merged 12 commits into from
Aug 5, 2024
Merged

Feature/generalize vector ingest #83

merged 12 commits into from
Aug 5, 2024

Conversation

ranchodeluxe
Copy link
Contributor

@ranchodeluxe ranchodeluxe commented Jul 20, 2023 •
edited
Loading

Addresses: https://github.com/NASA-IMPACT/veda-analytics/issues/80

Changes

  • remove all if/else condition so anything that gets dropped in the bucket "EIS/FEDSoutput/Snapshot/" or "EIS/FEDSoutput/LFArchive" will create a collection
  • write our own upsert logic b/c ogr2ogr with GPKG does not work even though their documentation says it does 😞

Note to Reviewer

This cannot be merged until Tess' changes are completed and merged in so hold tight 👍

@ranchodeluxe ranchodeluxe requested a review from smohiudd July 20, 2023 15:58
@ranchodeluxe ranchodeluxe requested a review from jjfrench November 6, 2023 13:41
@ranchodeluxe ranchodeluxe merged commit 8807b31 into dev Aug 5, 2024
10 checks passed
@ividito ividito deleted the feature/generalize_vector_ingest branch December 2, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjfrench jjfrench jjfrench approved these changes

@smohiudd smohiudd smohiudd approved these changes

Assignees

@smohiudd smohiudd

@jjfrench jjfrench

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranchodeluxe @smohiudd @jjfrench