Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or fix UnsupportedSearchProperty #528

Open
alexdunnjpl opened this issue Aug 21, 2024 · 2 comments
Open

Remove or fix UnsupportedSearchProperty #528

alexdunnjpl opened this issue Aug 21, 2024 · 2 comments

Comments

@alexdunnjpl
Copy link
Contributor

💡 Description

A custom exception UnsupportedSearchProperty is defined, and caught/handled all over the codebase, but is never thrown. It relates to the conversion between / and ., which cannot fail.

@jordanpadams @tloubrieu-jpl is it intended that properties be validated (if so, what validation rules?) or can this exception be stripped out of the codebase?

⚔️ Parent Epic / Related Tickets

No response

@alexdunnjpl
Copy link
Contributor Author

As part of this ticket, remove these utility functions and replace their usages with PdsProperty equivalents.

@jordanpadams
Copy link
Member

@alexdunnjpl I think eventually from an end user perspective it would be helpful to catch an incorrect search property from a typo or something like that, but we don't have that as a requirement right now. Since it is not being used properly at the moment, we can remove and add back later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Backlog
Development

No branches or pull requests

2 participants