Implement common multiple-products build method #517
Conversation
…cts() the semantics of the new name are clearer and cannot lead to confusion about its behaviour
|
Some routes do not currently have qparams/implementations for querystring and keywords, in which case no-op placeholders (null-string, empty keyword list) have been used. Those constraints may be desirable for those routes, in which case qparams can be defined and the no-op placeholders replaced with actual values from the request. |
|
Re-running branch tests, as failure was not replicable locally |
|
Not really sure where to go from here... @tloubrieu-jpl any ideas?
|
|
Hi @alexdunnjpl , is the latest case you raised an issue ? I am running now the test against the develop branch and all succeeded except one related to the legacy_registry. |
service/src/main/java/gov/nasa/pds/api/registry/controllers/ProductsController.java
Outdated
Show resolved
Hide resolved
service/src/main/java/gov/nasa/pds/api/registry/search/RegistrySearchRequestBuilder.java
Outdated
Show resolved
Hide resolved
This is the failure I'm referring to - for some reason when the tests are run in the action, it fails. I don't see any potential for the test definitions to be different between the runner and my local, since the URL is given in the action test output... |
|
@tloubrieu-jpl is the deep-archive compatibility check new-ish? Is it a blocker that it's failing? |
|
Merging on the basis of approval |
🗒️ Summary
Rolls build options common to all routes returning multiple product hits into a common execution path.
⚙️ Test Data and/or Report
130 pass, 10 fail, before and after changes
♻️ Related Issues
fixes #515